ci: fix validate-source checks vs stale labels#28843
Open
kolyshkin wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Added a test commit, waiting for the job to fail. |
Luap99
reviewed
Jun 3, 2026
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
added the label and clicked rerun
Note this must be fixed for the bloat approved label below in the same way then
| jq -r '.labels[].name') | ||
|
|
||
| if grep -F -x -q "$OVERRIDE_LABEL" <<<"$labels"; then | ||
| exit 0 |
Member
There was a problem hiding this comment.
maybe an echo here as debug log to say "$OVERRIDE_LABEL label found, ignoring test requirement" would help.
kolyshkin
force-pushed
the
should-include-tests
branch
from
1a4c1bb to
4c0500c
Compare
kolyshkin
changed the title
kolyshkin
force-pushed
the
should-include-tests
branch
from
4c0500c to
d5a001e
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
When the validate-source job is re-run manually after adding a label, it uses stale labels (from the "pull_request" event that originally triggered it), and so the steps that check labels don't see new labels. Fix by querying the labels live (similar to how it was done before commits 6e597af and 1da1541). Note the logic differs slightly between hack/ci/make-and-check-size.sh and hack/ci/pr-should-include-tests. This is because pr-should-include-tests is also executed locally as well as on non-PRs, while make-and-check-size is run strictly in CI for PRs only. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
should-include-tests
branch
from
d5a001e to
d05c113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the validate-source job is re-run manually after adding a label,
it uses stale labels (from the "pull_request" event that originally
triggered it), and so the steps that check labels don't see new labels.
Fix by querying the labels live (similar to how it was done before
commits 6e597af and 1da1541).
Note the logic differs slightly between hack/ci/make-and-check-size.sh
and hack/ci/pr-should-include-tests. This is because
pr-should-include-tests is also executed locally as well as on non-PRs,
while make-and-check-size is run strictly in CI for PRs only.
Fixes: #28838
Does this PR introduce a user-facing change?